Skip to content

EDM-3402: Use control variant for RichTextFIeld#545

Merged
celdrake merged 1 commit intoflightctl:mainfrom
celdrake:EDM-3402-show-constrol-input
Apr 8, 2026
Merged

EDM-3402: Use control variant for RichTextFIeld#545
celdrake merged 1 commit intoflightctl:mainfrom
celdrake:EDM-3402-show-constrol-input

Conversation

@celdrake
Copy link
Copy Markdown
Collaborator

@celdrake celdrake commented Feb 25, 2026

Using the control variant makes it visually clearer that the field has the same size as the rest of the fields.

control-added

Summary by CodeRabbit

  • Style
    • Updated the button styling used in form validation popovers, changing its visual appearance for improved consistency and readability.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b8b0b3a8-5c50-4175-a664-e65a11bb0115

📥 Commits

Reviewing files that changed from the base of the PR and between 8fb4cf7 and d4951ce.

📒 Files selected for processing (1)
  • libs/ui-components/src/components/form/RichValidationTextField.tsx
✅ Files skipped from review due to trivial changes (1)
  • libs/ui-components/src/components/form/RichValidationTextField.tsx

Walkthrough

Button variant in the validation popover of RichValidationTextField.tsx changed from "plain" to "control"; no other logic, exports, or control flow altered.

Changes

Cohort / File(s) Summary
Button Styling Update
libs/ui-components/src/components/form/RichValidationTextField.tsx
Changed Button component variant prop from "plain" to "control" inside the validation popover (styling-only change).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title references 'RichTextFIeld' but the actual change is to 'RichValidationTextField', and it mentions using the 'control variant' which matches the substantive change made to the Button component's variant prop. Correct the typo 'RichTextFIeld' to 'RichValidationTextField' to accurately reflect the component being modified.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@celdrake celdrake force-pushed the EDM-3402-show-constrol-input branch from 8fb4cf7 to d4951ce Compare April 8, 2026 08:46
@celdrake celdrake merged commit 325a780 into flightctl:main Apr 8, 2026
10 checks passed
@celdrake celdrake deleted the EDM-3402-show-constrol-input branch April 8, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants